Adds 'buildable' selection mode #6366
Conversation
dbeatty10
added
the
ready_for_review
| @@ -173,12 +174,14 @@ class BaseSelectionGroup(dbtClassMixin, Iterable[SelectionSpec], metaclass=ABCMe | |||
| def __init__( | |||
| self, | |||
| components: Iterable[SelectionSpec], | |||
| indirect_selection: IndirectSelection = IndirectSelection.Eager, | |||
There was a problem hiding this comment.
In case this is confusing - in selector.py on line 138 we need to get the indirect selection method from a composite spec (a union, difference, or intersection). This change here, and the changes in cli.py, add the indirect selection method to these composite specs through the BaseSelectionGroup so we can get them at that line in selector.py. Previously the indirect selection method was only on the SelectionCriteria object.
It's possible I misunderstood how something works here, but I couldn't find an easier way to get the indirect selection method at that point.
There was a problem hiding this comment.
Thanks for this note, really helpful!
AGPapa
force-pushed
the
main
branch
4 times, most recently
from
066f031
to
e1faafb
Compare
AGPapa
changed the title
|
@AGPapa Excited about the work you've done on this! 🤩 |
| @@ -173,12 +174,14 @@ class BaseSelectionGroup(dbtClassMixin, Iterable[SelectionSpec], metaclass=ABCMe | |||
| def __init__( | |||
| self, | |||
| components: Iterable[SelectionSpec], | |||
| indirect_selection: IndirectSelection = IndirectSelection.Eager, | |||
There was a problem hiding this comment.
Thanks for this note, really helpful!
resolves #6365
Description
This PR adds a new selection mode called 'buildable'. This selection mode runs tests if the test's parents are selected - or if the tests's parents are ancestors of what is selected. This change makes it easier to develop part of the graph and test changes on it. See the issue for a more detailed description.
I am able to make changes to this PR in response to feedback! As mentioned in the issue, I think that some or all of these changes could be made directly to the existing cautious mode, without making a new selection mode at all.
Checklist
buildableindirect selection mode docs.getdbt.com#2568changie newto create a changelog entry